[PATCH v2] nand: Add NAND driver for Mikrotik RB4xx series boards

Bert Vermeulen bert at biot.com
Fri May 8 07:29:27 PDT 2015


On 05/08/2015 12:14 PM, Frans Klaver wrote:
> On Thu, May 7, 2015 at 2:31 PM, Bert Vermeulen <bert at biot.com> wrote:
>> +
>> +       info->chip.priv = info;
>> +       info->mtd.priv  = &info->chip;
>> +       info->mtd.owner = THIS_MODULE;
> 
> If you should respin, could you add
> 
> info->mtd.dev.parent = &pdev->dev;
> 
> This will have a symlink to the parent device show up in sysfs. Seems
> some people feel rather strongly about that.

Sure, will do. I'll wait for some comment from David Woodhouse or Brian
Norris first, in case there's something more substantial to fix as well.


-- 
Bert Vermeulen        bert at biot.com          email/xmpp



More information about the linux-mtd mailing list