[PATCH 3/3] mtd: sh_flctl: remove unused variable and assignment

Nicholas Mc Guire hofrat at osadl.org
Fri May 1 07:16:03 PDT 2015


Fixes a compile warning [-Wunused-but-set-variable] only.

Signed-off-by: Nicholas Mc Guire <hofrat at osadl.org>
---

This fixes the compile time warning:
drivers/mtd/nand/sh_flctl.c: In function 'flctl_dma_fifo0_transfer':
drivers/mtd/nand/sh_flctl.c:354:15: warning: variable 'cookie' set but not
used [-Wunused-but-set-variable]

as dmaengine_submit only reads and returns desc->tx_submit(desc) which 
is then unused in flctl_dma_fifo0_transfer, this should be side-effect 
free to remove.

Patch was compile tested with ap325rxa_defconfig (implies
CONFIG_MTD_NAND_SH_FLCTL=y)

Patch is against 4.1-rc1 (localversion-next is -next-20150501)

 drivers/mtd/nand/sh_flctl.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c
index b9f265a..6a5c4f7 100644
--- a/drivers/mtd/nand/sh_flctl.c
+++ b/drivers/mtd/nand/sh_flctl.c
@@ -351,7 +351,6 @@ static int flctl_dma_fifo0_transfer(struct sh_flctl *flctl, unsigned long *buf,
 	struct dma_chan *chan;
 	enum dma_transfer_direction tr_dir;
 	dma_addr_t dma_addr;
-	dma_cookie_t cookie = -EINVAL;
 	uint32_t reg;
 	int ret;
 	unsigned long time_left;
@@ -377,7 +376,6 @@ static int flctl_dma_fifo0_transfer(struct sh_flctl *flctl, unsigned long *buf,
 
 		desc->callback = flctl_dma_complete;
 		desc->callback_param = flctl;
-		cookie = dmaengine_submit(desc);
 
 		dma_async_issue_pending(chan);
 	} else {
-- 
1.7.10.4




More information about the linux-mtd mailing list