[PATCH] UBI: fix missing brace control flow
Brian Norris
computersforpeace at gmail.com
Mon Mar 16 11:08:44 PDT 2015
On Mon, Feb 23, 2015 at 10:21:53PM +0100, Richard Weinberger wrote:
> Am 23.02.2015 um 22:07 schrieb Brian Norris:
> > commit 0e707ae79ba3 ("UBI: do propagate positive error codes up") seems
> > to have produced an unintended change in the control flow here.
> >
> > Completely untested, but it looks obvious.
> >
> > Caught by Coverity, which didn't like the indentation. CID 1271184.
> >
> > Signed-off-by: Brian Norris <computersforpeace at gmail.com>
> > Cc: Dan Carpenter <dan.carpenter at oracle.com>
> > ---
> > Should go into 4.0, I expect.
>
> Good catch, patch tested and applied!
Is this going in 4.0? It fixes a typo in a hastily-applied patch that
made it to 4.0-rc1.
I'm also not sure I understand the role of the +linux-next and +master
branches in linux-ubifs.git. Typically 'next' means for the current+1
release (i.e., 4.1), while 'not-next' (i.e., your master branch?) would
be for the current release (4.0). But you have +master based on top of
+linux-next.
Brian
More information about the linux-mtd
mailing list