[PATCH v2] Remove deprecated IRQF_DISABLED flag entirely

Valentin Rothberg valentinrothberg at gmail.com
Mon Mar 9 10:24:29 PDT 2015


On Mon, Mar 9, 2015 at 5:52 PM, Felipe Balbi <balbi at ti.com> wrote:
> Hi,
>
> On Thu, Mar 05, 2015 at 03:23:08PM +0100, Valentin Rothberg wrote:
>> The IRQF_DISABLED is a NOOP and has been scheduled for removal since
>> Linux v2.6.36 by commit 6932bf37bed4 ("genirq: Remove IRQF_DISABLED from
>> core code").
>>
>> According to commit e58aa3d2d0cc ("genirq: Run irq handlers with
>> interrupts disabled") running IRQ handlers with interrupts enabled can
>> cause stack overflows when the interrupt line of the issuing device is
>> still active.
>>
>> This patch ends the grace period for IRQF_DISABLED (i.e., SA_INTERRUPT
>> in older versions of Linux) and removes the definition and all remaining
>> usages of this flag.
>>
>> Signed-off-by: Valentin Rothberg <valentinrothberg at gmail.com>
>> ---
>> The bigger hunk in Documentation/scsi/ncr53c8xx.txt is removed entirely
>> as IRQF_DISABLED is gone now; the usage in older kernel versions
>> (including the old SA_INTERRUPT flag) should be discouraged.  The
>> trouble of using IRQF_SHARED is a general problem and not specific to
>> any driver.
>>
>> I left the reference in Documentation/PCI/MSI-HOWTO.txt untouched since
>> it has already been removed in linux-next by commit b0e1ee8e1405
>> ("MSI-HOWTO.txt: remove reference on IRQF_DISABLED").
>>
>> All remaining references are changelogs that I suggest to keep.
>>
>> Changelog
>>
>> v2: Correct previous change to drivers/mtd/nand/hisi504_nand.c that
>> broke compilation.  Reported by Dan Carpenter.
>> ---
>>  drivers/usb/isp1760/isp1760-core.c   |  3 +--
>>  drivers/usb/isp1760/isp1760-udc.c    |  4 ++--
>
> I have a commit in my tree for isp1760:
>
> https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/fixes&id=80b4a0f8feeb6ee7fa4430a2b4ae1155ed923bd2

I am sorry, but I did not receive an email that it has been applied.
Andrew asked me to do this patch, so I replied to the one you
mentioned to avoid this conflict:

http://comments.gmane.org/gmane.linux.kernel/1896211

Kind regards,
 Valentin



More information about the linux-mtd mailing list