[PATCH 01/60] mtd: core: tone down suggestion that dev.parent should be set

Frans Klaver fransklaver at gmail.com
Tue Mar 3 13:39:45 PST 2015


add_mtd_device() has a comment suggesting that the caller should have
set dev.parent. This is required to have the device show up in sysfs,
but not for proper operation of the mtd device itself. Currently we have
five drivers registering mtd devices during module initialization, so
they don't actually provide a parent device to link to. That means we
cannot WARN_ON() here, as it would trigger false positives.

Make the comment a bit less firm in its assertion that dev.parent should
be set.

Signed-off-by: Frans Klaver <fransklaver at gmail.com>
---
 drivers/mtd/mtdcore.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index 11883bd..2093676 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -422,7 +422,7 @@ int add_mtd_device(struct mtd_info *mtd)
 	}
 
 	/* Caller should have set dev.parent to match the
-	 * physical device.
+	 * physical device, if appropriate.
 	 */
 	mtd->dev.type = &mtd_devtype;
 	mtd->dev.class = &mtd_class;
-- 
2.2.2




More information about the linux-mtd mailing list