[PATCH 0/2] mtd: nandsim: fix error handling

Richard Weinberger richard at nod.at
Mon Jun 22 23:26:40 PDT 2015


Am 23.06.2015 um 03:03 schrieb Sheng Yong:
> Ping. Any comments are appreciated :)
> 
> thanks,
> Sheng
> 
> On 6/17/2015 4:45 PM, Sheng Yong wrote:
>> These 2 patches fix error handling when nandsim initialization fails.
>>
>> In alloc_device(), if creating slab memory fails, free_device() will try
>> to destroy the slab memory without checking if it exists.  PATCH 1 fixes
>> it.
>>
>> If something goes wrong in init_nandsim(), it calls free_device() before
>> returning. However, the caller of init_nandsim() - ns_init_module() - also
>> does the cleanup by calling free_nandsim(). This causes double free. PATCH
>> 2 fixes it.
>>
>> Thanks,
>> Sheng
>>
>> Sheng Yong (2):
>>   mtd: nandsim: fix free of NULL pointer
>>   mtd: nandsim: fix double free

Both patches look good to me.

Thanks,
//richard



More information about the linux-mtd mailing list