[RFC PATCH v2 0/6] UBI: Some cleanup and check if a vol exists when fastmap attaching

Richard Weinberger richard at nod.at
Tue Jun 2 03:01:21 PDT 2015


Am 02.06.2015 um 02:38 schrieb Sheng Yong:
> Ping.
> 
> On 5/26/2015 6:07 PM, Sheng Yong wrote:
>> Hi, folks,
>>
>> V2:
>> * change the commit message of PATCH 5. In normal cases, including unclean
>>   reboot and ECC scenario, there is no way to have two same vol_id saved in
>>   different slots in ubi->volumes[], so add_vol() in fastmap attach won't
>>   go wrong. Only if the on-flash fastmap is modified by hand, this issue
>>   may be triggered.
>>   Thanks Richard Weinberger for pointing this out.
>>
>> * add two more cleanup.
>>   . add a helper function for updatting on-flash layout volumes. No
>>     semantic changes.
>>
>> V1:
>> http://lists.infradead.org/pipermail/linux-mtd/2015-May/059355.html
>>
>> Thanks,
>> Sheng
>>
>> Sheng Yong (6):
>>   UBI: Fastmap: Use max() to get the larger value
>>   UBI: Fastmap: Remove unnecessary `\'
>>   UBI: Fastmap: Rename variables to make them meaningful
>>   UBI: Init vol->reserved_pebs by assignment
>>   UBI: Fastmap: Do not add vol if it already exists
>>   UBI: add a helper function for updatting on-flash layout volumes
>>
>>  drivers/mtd/ubi/build.c   |  4 +--
>>  drivers/mtd/ubi/fastmap.c | 81 +++++++++++++++++++++++++----------------------
>>  drivers/mtd/ubi/vmt.c     |  4 +--
>>  drivers/mtd/ubi/vtbl.c    | 45 ++++++++++++++------------
>>  4 files changed, 72 insertions(+), 62 deletions(-)

Thanks you Sheng, all 6 patches are applied now!
BTW: You could also remove `\' from other places in UBI.

Thanks,
//richard



More information about the linux-mtd mailing list