[PATCH v3] UBI: block: Dynamically allocate minor numbers

Richard Weinberger richard at nod.at
Tue Jun 2 02:37:10 PDT 2015


Am 22.04.2015 um 00:57 schrieb Ezequiel Garcia:
> 
> 
> On 03/19/2015 11:38 AM, Ezequiel Garcia wrote:
>>
>>
>> On 03/17/2015 02:37 PM, Dan Ehrenberg wrote:
>>> This patch makes ubiblock devices have minor numbers beginning from
>>> 0, allocated dynamically independently of the ubi device/volume
>>> number. This property becomes useful because, on 32-bit architectures
>>> with LFS turned off in a userspace program, device minor numbers
>>> over 8 bits cause stat to return -EOVERFLOW. If the device number is
>>> high (>1) due to multiple MTD partitions, such an overflow will occur.
>>> While enabling LFS is clearly a nicer solution, it's often difficult
>>> to turn on in practice globally as many widely distributed packages
>>> don't work with LFS on.
>>>
>>> Other storage systems have their own workarounds, with SCSI making
>>> multiple device majors and MMC having a config option for the number
>>> of partitions per device. A completely dynamic minor numbering is
>>> simpler than these. It is unlikely that anyone is depending on a
>>> static minor number since the major is dynamic anyway. In addition,
>>> ubiblock is still relatively new, so now is the time to make such
>>> changes.
>>>
>>> Signed-off-by: Dan Ehrenberg <dehrenberg at chromium.org>
>>>
>>
>> Acked-by: Ezequiel Garcia <ezequiel at vanguardiasur.com.ar>
>>
> 
> Hm.. it seems this one fell through the cracks :/ Richard?

Yep. :(
Applied to my 4.2 queue!

Thanks everyone!
//richard



More information about the linux-mtd mailing list