[RFC PATCH 2/2] dt: spi: s3c64xx: add compatible to controller-data
Michal Suchanek
hramrach at gmail.com
Wed Jul 29 03:19:57 PDT 2015
The controller-data subnode has no compatible. This can lead to other
drivers getting confused by it. Add a compatible to make devicetreee
unambiguous.
Signed-off-by: Michal Suchanek <hramrach at gmail.com>
---
Documentation/devicetree/bindings/spi/spi-samsung.txt | 3 +++
drivers/spi/spi-s3c64xx.c | 4 ++++
2 files changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/spi/spi-samsung.txt b/Documentation/devicetree/bindings/spi/spi-samsung.txt
index 6dbdeb3..b1e98d1 100644
--- a/Documentation/devicetree/bindings/spi/spi-samsung.txt
+++ b/Documentation/devicetree/bindings/spi/spi-samsung.txt
@@ -92,16 +92,19 @@ Example:
spi-max-frequency = <10000>;
controller-data {
+ compatible = "samsung,s3c-controller-data";
samsung,spi-feedback-delay = <0>;
};
partition at 0 {
+ compatible = "linux,ofpart-partition";
label = "U-Boot";
reg = <0x0 0x40000>;
read-only;
};
partition at 40000 {
+ compatible = "linux,ofpart-partition";
label = "Kernel";
reg = <0x40000 0xc0000>;
};
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 2a8c513..9964db3 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -760,6 +760,10 @@ static struct s3c64xx_spi_csinfo *s3c64xx_get_slave_ctrldata(
dev_err(&spi->dev, "child node 'controller-data' not found\n");
return ERR_PTR(-EINVAL);
}
+ if (!of_get_property(data_np, "compatible", NULL) ||
+ strcmp(of_get_property(data_np, "compatible", NULL),
+ "samsung,s3c-controller-data"))
+ dev_err(&spi->dev, "child node 'controller-data' does not have correct compatible\n");
cs = kzalloc(sizeof(*cs), GFP_KERNEL);
if (!cs) {
--
2.1.4
More information about the linux-mtd
mailing list