[PATCH] jffs2: remove unneeded kfree
Brian Norris
computersforpeace at gmail.com
Mon Jul 6 15:27:40 PDT 2015
On Thu, Jun 25, 2015 at 03:29:37PM +0800, Wei Fang wrote:
> c->oobbuf hasn't been kmalloced in jffs2_dataflash_setup, so
> there is no need to free it.
>
> Signed-off-by: Wei Fang <fangwei1 at huawei.com>
> ---
> fs/jffs2/wbuf.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/jffs2/wbuf.c b/fs/jffs2/wbuf.c
> index 09ed551..63f31c0 100644
> --- a/fs/jffs2/wbuf.c
> +++ b/fs/jffs2/wbuf.c
> @@ -1274,7 +1274,6 @@ int jffs2_dataflash_setup(struct jffs2_sb_info *c) {
> #ifdef CONFIG_JFFS2_FS_WBUF_VERIFY
> c->wbuf_verify = kmalloc(c->wbuf_pagesize, GFP_KERNEL);
> if (!c->wbuf_verify) {
> - kfree(c->oobbuf);
> kfree(c->wbuf);
> return -ENOMEM;
> }
I just realized I responded to your email from months ago. But I see you
sent the same patch here. Both are similarly whitespace damaged. Please
fix and test on your end before resending again.
Thanks,
Brian
More information about the linux-mtd
mailing list