Query on ubifs_assert

[pavi1729]

Thanks Richard.. that helped.

Started with UBI.. like 3 days back. Will keep digging.

On Wed, Jul 1, 2015 at 7:41 PM, Richard Weinberger
<richard.weinberger at gmail.com> wrote:
> On Wed, Jul 1, 2015 at 1:03 PM, pavi1729 <pavitra1729 at gmail.com> wrote:
>> Hi,
>>
>>  FILE: fs/ubifs/misc.h :
>>  FUNCTION : ubifs_compr_present
>>
>> "ubifs_compr_present" function has "ubifs_assert" which checks for the
>> valid compression value
>> and does a stack_dump if not.
>>
>> Could there be a case where the "compr_type" is corrupt; if yes, then
>> does a stack_dump  suffice?
>> Thus if compr_type is invalid then the below return is not reliable.
>>     return !!ubifs_compressors[compr_type]->capi_name;
>
> If compr_type is invalid something nasty is happening and the kernel will crash
> at some point.
> But using the ubifs_assert() we can see at least what went wrong.
>
>> So where does this end, eventually does it go to a point where the
>> volume get corrupt and not unmountable ?
>
> As I said, if that value is corrupt we are already in trouble.
> The purpose of the assert is to report which value is bad.
>
> --
> Thanks,
> //richard