[PATCH] jffs2:Remove no longer needed fix me comment for the function, jffs2_do_readpage_nolock

Nicholas Krause xerofoify at gmail.com
Sat Jan 31 11:11:58 PST 2015


This fix me comment is no longer needed due to kmap not being able to fail and always
returning a address mapped in high memory as required for this function. There for
this fix me can now be removed as kmap always succeeds and there is no reason to
check if it fails.

Signed-off-by: Nicholas Krause <xerofoify at gmail.com>
---
 fs/jffs2/file.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/jffs2/file.c b/fs/jffs2/file.c
index 64989ca..84a2f7b 100644
--- a/fs/jffs2/file.c
+++ b/fs/jffs2/file.c
@@ -94,7 +94,6 @@ static int jffs2_do_readpage_nolock (struct inode *inode, struct page *pg)
 	BUG_ON(!PageLocked(pg));
 
 	pg_buf = kmap(pg);
-	/* FIXME: Can kmap fail? */
 
 	ret = jffs2_read_inode_range(c, f, pg_buf, pg->index << PAGE_CACHE_SHIFT, PAGE_CACHE_SIZE);
 
-- 
2.1.0




More information about the linux-mtd mailing list