[patch] mtd: hisilicon: && vs & typo

Brian Norris computersforpeace at gmail.com
Thu Feb 12 13:37:40 PST 2015


Hi,

On Wed, Feb 11, 2015 at 01:25:09PM +0300, Dan Carpenter wrote:
> The intent was to mask away some bits here, not to test true or false.
> 
> Fix: 54f531f6e332 ('mtd: hisilicon: add a new NAND controller driver for hisilicon hip04 Soc')
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> 
> diff --git a/drivers/mtd/nand/hisi504_nand.c b/drivers/mtd/nand/hisi504_nand.c
> index 484e1db..289ad3a 100644
> --- a/drivers/mtd/nand/hisi504_nand.c
> +++ b/drivers/mtd/nand/hisi504_nand.c
> @@ -495,7 +495,7 @@ static void hisi_nfc_cmdfunc(struct mtd_info *mtd, unsigned command, int column,
>  		flag = hinfc_read(host, HINFC504_CON);
>  		if (chip->ecc.mode == NAND_ECC_HW)
>  			hinfc_write(host,
> -				    flag && ~(HINFC504_CON_ECCTYPE_MASK <<
> +				    flag & ~(HINFC504_CON_ECCTYPE_MASK <<

Looks good to me. Zhou, can I get an ack?

>  				    HINFC504_CON_ECCTYPE_SHIFT), HINFC504_CON);
>  
>  		host->offset = 0;

Brian



More information about the linux-mtd mailing list