[RFC PATCH] ubifs: do not write master node if recovery needed

Artem Bityutskiy dedekind1 at gmail.com
Fri Feb 6 09:29:31 PST 2015


On Thu, 2015-02-05 at 09:54 +0000, Sheng Yong wrote:
> If unclean umount happens, ubifs may fail when mounting. Trying to mount
> it will write new master nodes on the flash. This is useless but wasting
> space and increasing sqnum. So check need_recovery before writing master
> node, and don't create new master node if filesystem needs recovery.

Looks like you caught a bug, thanks, but I need to check the code a bit
more carefully. So when will the master not be updated then, if you do
not mark it dirty now?

Artem.




More information about the linux-mtd mailing list