[PATCH v2 03/25] cris: nand: make use of mtd_to_nand() where appropriate
Jesper Nilsson
jesper.nilsson at axis.com
Tue Dec 8 00:32:40 PST 2015
On Mon, Dec 07, 2015 at 07:27:40PM -0800, Brian Norris wrote:
> (Reducing CC)
>
> Hi Mikael and Jesper,
>
> On Tue, Dec 01, 2015 at 12:03:00PM +0100, Boris Brezillon wrote:
> > mtd_to_nand() was recently introduced to avoid direct accesses to the
> > mtd->priv field. Update all CRIS specific implementations to use this
> > helper.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon at free-electrons.com>
> > ---
> > arch/cris/arch-v32/drivers/mach-a3/nandflash.c | 2 +-
> > arch/cris/arch-v32/drivers/mach-fs/nandflash.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/cris/arch-v32/drivers/mach-a3/nandflash.c b/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
> > index 7fb5212..db953cf 100644
> > --- a/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
> > +++ b/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
> > @@ -52,7 +52,7 @@ static void crisv32_hwcontrol(struct mtd_info *mtd, int cmd,
> > {
> > unsigned long flags;
> > reg_pio_rw_dout dout;
> > - struct nand_chip *this = mtd->priv;
> > + struct nand_chip *this = mtd_to_nand(mtd);
> >
> > local_irq_save(flags);
> >
> > diff --git a/arch/cris/arch-v32/drivers/mach-fs/nandflash.c b/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
> > index e032384..22a6467 100644
> > --- a/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
> > +++ b/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
> > @@ -51,7 +51,7 @@ static void crisv32_hwcontrol(struct mtd_info *mtd, int cmd,
> > {
> > unsigned long flags;
> > reg_gio_rw_pa_dout dout;
> > - struct nand_chip *this = mtd->priv;
> > + struct nand_chip *this = mtd_to_nand(mtd);
> >
> > local_irq_save(flags);
> >
>
> Acked-by: Brian Norris <computersforpeace at gmail.com>
>
> This patch and patch 18 touch arch/cris/ marginally. It's a little
> complicated to give you all the dependencies for the later stuff without
> bringing in a bunch of MTD stuff. I plan to take them both to MTD
> directly. An ack would be nice.
Sure, looks good, and thanks for the reminder.
Acked-by: Jesper Nilsson <jesper.nilsson at axis.com>
> Regards,
> Brian
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson at axis.com
More information about the linux-mtd
mailing list