[PATCH v2 02/25] blackfin: nand: make use of mtd_to_nand() where appropriate
Brian Norris
computersforpeace at gmail.com
Mon Dec 7 19:20:59 PST 2015
(Reducing CC, since adi-buildroot-devel at lists.sourceforge.net doesn't
like that many...)
Hi Steven,
On Tue, Dec 01, 2015 at 12:02:59PM +0100, Boris Brezillon wrote:
> mtd_to_nand() was recently introduced to avoid direct accesses to the
> mtd->priv field. Update all blackfin specific implementations to use
> this helper.
>
> Signed-off-by: Boris Brezillon <boris.brezillon at free-electrons.com>
> ---
> arch/blackfin/mach-bf537/boards/stamp.c | 2 +-
> arch/blackfin/mach-bf561/boards/acvilon.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/blackfin/mach-bf537/boards/stamp.c b/arch/blackfin/mach-bf537/boards/stamp.c
> index 88a19fc..c181543 100644
> --- a/arch/blackfin/mach-bf537/boards/stamp.c
> +++ b/arch/blackfin/mach-bf537/boards/stamp.c
> @@ -404,7 +404,7 @@ static struct mtd_partition bfin_plat_nand_partitions[] = {
> #define BFIN_NAND_PLAT_ALE 1
> static void bfin_plat_nand_cmd_ctrl(struct mtd_info *mtd, int cmd, unsigned int ctrl)
> {
> - struct nand_chip *this = mtd->priv;
> + struct nand_chip *this = mtd_to_nand(mtd);
>
> if (cmd == NAND_CMD_NONE)
> return;
> diff --git a/arch/blackfin/mach-bf561/boards/acvilon.c b/arch/blackfin/mach-bf561/boards/acvilon.c
> index 6ab9515..37f8f25 100644
> --- a/arch/blackfin/mach-bf561/boards/acvilon.c
> +++ b/arch/blackfin/mach-bf561/boards/acvilon.c
> @@ -267,7 +267,7 @@ static struct mtd_partition bfin_plat_nand_partitions[] = {
> static void bfin_plat_nand_cmd_ctrl(struct mtd_info *mtd, int cmd,
> unsigned int ctrl)
> {
> - struct nand_chip *this = mtd->priv;
> + struct nand_chip *this = mtd_to_nand(mtd);
>
> if (cmd == NAND_CMD_NONE)
> return;
FWIW:
Acked-by: Brian Norris <computersforpeace at gmail.com>
What would you like done with this? I can just take it via MTD, since
it's pretty small. Or I can queue up this and 1 dependent change as a
pull request for you.
Regards,
Brian
More information about the linux-mtd
mailing list