[PATCH 1/2] ubifs: Remove dead xattr code
Richard Weinberger
richard at nod.at
Wed Aug 19 23:45:37 PDT 2015
Am 20.08.2015 um 04:48 schrieb Dongsheng Yang:
> On 08/20/2015 04:35 AM, Richard Weinberger wrote:
>> This is a partial revert of commit d7f0b70d30ffb9bbe6b8a3e1035cf0b79965ef53
>> ("UBIFS: Add security.* XATTR support for the UBIFS").
>
> Hi Richard,
> What about a full reverting of this commit. In ubifs, we
> *can* support any namespace of xattr including user, trusted, security
> or other anyone prefixed by any words. But we have a check_namespace()
> in xattr.c to limit what we want to support. That said, if we want to
> "Add security.* XATTR support for the UBIFS", what we need to do is
> just extending the check_namespace() to allow security namespace pass.
> And yes, check_namespace() have been supporting security namespace.
You're right. I thought/hoped we can re-use some parts of it.
Se let's do a full revert. I'll send a v2 patch in a jiffy.
> So, IMHO, we do not depend on the generic mechanism at all, and we can
> fully revert this commit.
>
> But strange to me, why we picked this commit for ubifs? Artem, is there
> something I am missing?
TBH, I fear nobody noticed. :(
Thanks,
//richard
More information about the linux-mtd
mailing list