[kernel.org bug 103071] Dead "security.*" xattr code in ubifs

[Richard Weinberger]

Am 19.08.2015 um 03:37 schrieb Sheng Yong:
> 
> 
> On 8/19/2015 9:07 AM, Sheng Yong wrote:
>> Hi,
>>
>> On 8/19/2015 4:55 AM, Richard Weinberger wrote:
>>> Andreas,
>>>
>>> On Tue, Aug 18, 2015 at 2:15 PM, Andreas Grünbacher
>>> <andreas.gruenbacher at gmail.com> wrote:
>>>> Hello,
>>>>
>>>> FYI, I've filed the following bug report against ubifs:
>>>>
>>>>> ubifs sets sb->s_xattr to ubifs_xattr_handlers which contains a handler for
>>>>> "security.*" xattrs. The s_xattr handlers are never used because ubifs uses
>>>>> its own ubifs_{get,set,list,remove}xattr inode operations instead of
>>>>> generic_{get,set,list,remove}xattr inode operations though.
>>>>
>>>> https://bugzilla.kernel.org/show_bug.cgi?id=103071
>>>
>>> Thanks for reporting.
> My bad for didn't reply at the right line :(
>> This is because UBIFS did not implement extended attribute in the geneirc way
>> (by calling generic_*xattr()). We could create an xattr_handler to have these
>> dead functions called (in fact, I did that), but doing this seems just another
>> encapsulation and makes no sense. So I think we could remove these dead code
>> directly.

So, that would be a revert of commit d7f0b70d30ffb9bbe6b8a3e1035cf0b79965ef53?
I don't get what d7f0b70d30ffb9bbe6b8a3e1035cf0b79965ef53 was supposed to do
as it seems to be a no-op. :-)

Thanks,
//richard