[PATCH 1/3] MTD: m25p80: fix write return value.

Michal Suchanek hramrach at gmail.com
Thu Apr 30 06:33:47 PDT 2015


The 'retlen' points to a variable representing the number of data bytes
written/read (see include/linux/mtd/mtd.h) by the current invocation of
the function. This variable must be set, not incremented.

v2: clearer commit message

Signed-off-by: Michal Suchanek <hramrach at gmail.com>
Acked-by: Marek Vasut <marex at denx.de>
---
 drivers/mtd/devices/m25p80.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index 7c8b169..0b2bc21 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -102,7 +102,7 @@ static void m25p80_write(struct spi_nor *nor, loff_t to, size_t len,
 
 	spi_sync(spi, &m);
 
-	*retlen += m.actual_length - cmd_sz;
+	*retlen = m.actual_length - cmd_sz;
 }
 
 static inline unsigned int m25p80_rx_nbits(struct spi_nor *nor)
-- 
2.1.4




More information about the linux-mtd mailing list