[PATCH] UBI: block: Add missing cache flushes

Ezequiel Garcia ezequiel.garcia at imgtec.com
Wed Apr 22 05:30:53 PDT 2015


From: Kevin Cernekee <cernekee at chromium.org>

Block drivers are responsible for calling flush_dcache_page() on each
BIO request. This operation keeps the I$ coherent with the D$ on
architectures that don't have hardware coherency support. Without this
flush, random crashes are seen when executing user programs from an ext4
filesystem backed by a ubiblock device.

This patch is based on the change implemented in commit 2d4dc890b5c8
("block: add helpers to run flush_dcache_page() against a bio and a
request's pages").

Fixes: 9d54c8a33eec ("UBI: R/O block driver on top of UBI volumes")
Signed-off-by: Kevin Cernekee <cernekee at chromium.org>
Signed-off-by: Ezequiel Garcia <ezequiel.garcia at imgtec.com>
---
 drivers/mtd/ubi/block.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mtd/ubi/block.c b/drivers/mtd/ubi/block.c
index db2c05b..c9eb78f 100644
--- a/drivers/mtd/ubi/block.c
+++ b/drivers/mtd/ubi/block.c
@@ -310,6 +310,8 @@ static void ubiblock_do_work(struct work_struct *work)
 	blk_rq_map_sg(req->q, req, pdu->usgl.sg);
 
 	ret = ubiblock_read(pdu);
+	rq_flush_dcache_pages(req);
+
 	blk_mq_end_request(req, ret);
 }
 
-- 
2.3.3




More information about the linux-mtd mailing list