[PATCH] mtd: Add simple read disturb test

Richard Weinberger richard at nod.at
Thu Apr 2 07:56:50 PDT 2015


Am 02.04.2015 um 16:45 schrieb Fabio Estevam:
> On Thu, Apr 2, 2015 at 11:33 AM, Richard Weinberger <richard at nod.at> wrote:
> 
>> Why? Free()ing a NULL pointer is perfectly fine.
>> What did I miss? :)
> 
> If the first 'iobuf = kmalloc(mtd->erasesize, GFP_KERNEL);' fails then
> you jump to the out label where you call 5 kfree() and then return the
> error.
> 
> It would be much better just to return the error immediately in this
> case and add one label for each allocation error, so that it only
> kfree the previous successful allocations.

It is not *much* better. It is just a matter of taste.

Thanks,
//richard



More information about the linux-mtd mailing list