[PATCH V2 linux-next] jffs2: fix sparse warning: unexpected unlock

Fabian Frederick fabf at skynet.be
Sun Sep 28 12:26:32 PDT 2014


fs/jffs2/summary.c:846:5: warning: context imbalance in 'jffs2_sum_write_sumnode' - unexpected unlock

Suggested-by: Brian Norris <computersforpeace at gmail.com>
Suggested-by: Josh Triplett <josh at joshtriplett.org>
Signed-off-by: Fabian Frederick <fabf at skynet.be>
---
V2: use __must_hold instead of __releases / __acquires
(suggested by Brian Norris and Josh Triplett)

 fs/jffs2/summary.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/jffs2/summary.c b/fs/jffs2/summary.c
index c522d09..bc53854 100644
--- a/fs/jffs2/summary.c
+++ b/fs/jffs2/summary.c
@@ -844,6 +844,7 @@ static int jffs2_sum_write_data(struct jffs2_sb_info *c, struct jffs2_eraseblock
 /* Write out summary information - called from jffs2_do_reserve_space */
 
 int jffs2_sum_write_sumnode(struct jffs2_sb_info *c)
+	__must_hold(&c->erase_completion_block)
 {
 	int datasize, infosize, padsize;
 	struct jffs2_eraseblock *jeb;
-- 
1.9.1




More information about the linux-mtd mailing list