[PATCH 2/4] mtd: bcm47xxnflash: add dev_ready and fill chip_delay

[Rafał Miłecki]

On 18 September 2014 08:27, Brian Norris <computersforpeace at gmail.com> wrote:
> On Tue, Aug 19, 2014 at 09:14:14AM +0200, Rafał Miłecki wrote:
>> +
>> +     nand_chip->chip_delay = 50;
>
> I'm curious, did you have a good reason to use something other than the
> default provided by nand_base?

I simply followed what Broadcom used in their ugly code (don't look to
deep into that file, or you'll go crazy):
http://svn.dd-wrt.com/browser/src/linux/universal/linux-3.8/drivers/mtd/bcm947xx/nand/brcmnand_47xx.c?rev=22249#L2240

They set "dev_ready" as well as "chip_delay" (to the 50), so the only
case where they use this delay is
NAND_CMD_STATUS_ERROR
NAND_CMD_STATUS_ERROR[0-3]

Do you think we should try to stay with the default value?

-- 
Rafał