xfstests on UBIFS - first findings

[Richard Weinberger]

Am 16.09.2014 17:44, schrieb Artem Bityutskiy:
> On Mon, 2014-09-15 at 11:13 +0200, Richard Weinberger wrote:
>> One can simple trigger it by doing:
>> # mknod foo c 0 0
>> # setfattr -h -n trusted.name foo
>>
>> dir_ui->data_len is 4 instead of 0.
> 
> I think the assertion is bogus. It was correct before the xattr support
> was added.
> 
> The assertion basically is: if the inode is a directory inode, it should
> not have data in it.
> 
> In that function, dir_ui (directory UBIFS inode) may be also be the
> "host" inode for the xattr entry, so it is not necessarily a directory
> inode at all.
> 
> So the variable should be re-named to "host_ui" instead of "dir_ui".

Thanks for the explanation.
I'll prepare a patch for that and give more testing tomorrow!

Thanks,
//richard