mtd-utils-1.5.1 bug report

Artem Bityutskiy dedekind1 at gmail.com
Mon Sep 8 04:50:01 PDT 2014


On Sun, 2014-09-07 at 14:58 +0000, David Binderman wrote:
> Hello there,
> 
> ubi-utils/ubiformat.c:636:28: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
> 
>                 if (!args.subpage_size != mtd->min_io_size)
>                     normsg("may be sub-page size is "
>                            "incorrect?");
> 
> Something boolean compared to a size. Looks a possible problem to me.
> Removal of the double negative might also help.

Care to send a patch?

-- 
Best Regards,
Artem Bityutskiy




More information about the linux-mtd mailing list