[PATCH 7/7] mtd: denali: fix indentations and other trivial things

Masahiro Yamada yamada.m at jp.panasonic.com
Mon Sep 8 02:14:48 PDT 2014


Hi Josh,


On Mon, 8 Sep 2014 01:39:20 -0700
Josh Triplett <josh at joshtriplett.org> wrote:

> On Mon, Sep 08, 2014 at 05:10:13PM +0900, Masahiro Yamada wrote:
> > @@ -406,9 +404,9 @@ static void get_hynix_nand_para(struct denali_nand_info *denali,
> >  		break;
> >  	default:
> >  		dev_warn(denali->dev,
> > -			"Spectra: Unknown Hynix NAND (Device ID: 0x%x)."
> > -			"Will use default parameter values instead.\n",
> > -			device_id);
> > +			 "Spectra: Unknown Hynix NAND (Device ID: 0x%x)."
> > +			 "Will use default parameter values instead.\n",
> > +			 device_id);
> 
> Please join quoted strings into a single line.
> 
> > -		pr_err("Your NAND chip OOB is not large enough to \
> > -				contain 8bit ECC correction codes");
> > +		pr_err("Your NAND chip OOB is not large enough to "
> > +		       "contain 8bit ECC correction codes");
> 
> Likewise.
> 

Thanks for your review, but
the quoted strings are too long to be joined into a single line.
(exceed 80 columns)


Best Regards
Masahiro Yamada




More information about the linux-mtd mailing list