[PATCH 5/7] mtd: denali: remove a set-but-unused variable

Josh Triplett josh at joshtriplett.org
Mon Sep 8 01:30:57 PDT 2014


On Mon, Sep 08, 2014 at 05:10:11PM +0900, Masahiro Yamada wrote:
> The variable "retry" in wait_for_irq() is set, but not referenced.
> 
> Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>

Sure enough.

Reviewed-by: Josh Triplett <josh at joshtriplett.org>

> 
>  drivers/mtd/nand/denali.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
> index 259ca0ba..d37c2e1 100644
> --- a/drivers/mtd/nand/denali.c
> +++ b/drivers/mtd/nand/denali.c
> @@ -697,7 +697,6 @@ static uint32_t wait_for_irq(struct denali_nand_info *denali, uint32_t irq_mask)
>  {
>  	unsigned long comp_res;
>  	uint32_t intr_status;
> -	bool retry = false;
>  	unsigned long timeout = msecs_to_jiffies(1000);
>  
>  	do {
> @@ -717,7 +716,6 @@ static uint32_t wait_for_irq(struct denali_nand_info *denali, uint32_t irq_mask)
>  			 * need to wait again
>  			 */
>  			spin_unlock_irq(&denali->irq_lock);
> -			retry = true;
>  		}
>  	} while (comp_res != 0);
>  
> -- 
> 1.9.1
> 



More information about the linux-mtd mailing list