[PATCH 1/4] UBIFS: fix a couple bugs in UBIFS xattr length calculation
Ben Shelton
ben.shelton at ni.com
Fri Oct 31 11:50:28 PDT 2014
From: Subodh Nijsure <snijsure at grid-net.com>
Signed-off-by: Subodh Nijsure <snijsure at grid-net.com>
Signed-off-by: Marc Kleine-Budde <mkl at pengutronix.de>
Signed-off-by: Ben Shelton <ben.shelton at ni.com>
Acked-by: Brad Mouring <brad.mouring at ni.com>
Acked-by: Gratian Crisan <gratian.crisan at ni.com>
---
fs/ubifs/journal.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c
index fb166e2..7d90f13 100644
--- a/fs/ubifs/journal.c
+++ b/fs/ubifs/journal.c
@@ -571,7 +571,13 @@ int ubifs_jnl_update(struct ubifs_info *c, const struct inode *dir,
aligned_dlen = ALIGN(dlen, 8);
aligned_ilen = ALIGN(ilen, 8);
- len = aligned_dlen + aligned_ilen + UBIFS_INO_NODE_SZ;
+
+ /*
+ * Make sure to account for dir_ui->data_len in the length calculation
+ * in case there is an extended attribute.
+ */
+ len = aligned_dlen + aligned_ilen +
+ UBIFS_INO_NODE_SZ + dir_ui->data_len;
dent = kmalloc(len, GFP_NOFS);
if (!dent)
return -ENOMEM;
@@ -648,7 +654,8 @@ int ubifs_jnl_update(struct ubifs_info *c, const struct inode *dir,
ino_key_init(c, &ino_key, dir->i_ino);
ino_offs += aligned_ilen;
- err = ubifs_tnc_add(c, &ino_key, lnum, ino_offs, UBIFS_INO_NODE_SZ);
+ err = ubifs_tnc_add(c, &ino_key, lnum, ino_offs,
+ UBIFS_INO_NODE_SZ + dir_ui->data_len);
if (err)
goto out_ro;
--
2.1.1
More information about the linux-mtd
mailing list