[PATCH] mtd: spi-nor: Move n25q032 entry to Micron devices list

[Rafał Miłecki]

On 29 October 2014 15:05, Marek Vasut <marex at denx.de> wrote:
> On Wednesday, October 29, 2014 at 10:57:55 AM, Chunhe Lan wrote:
>
> [...]
>
> There are problems with this patch. Firstly, it misses any description
> explaining why the change took place at all. From an outside observer
> point of view, this change seems random at best.

This looks like a normal cleaning for me.


> Secondly, the change in itself makes no sense -- it just reorders the
> entries in an array.

It moves Micron entry to the Micron pseudo-group, which makes sense to me.


> I can only speculate here, that your SPI NOR was
> recognised as some other part, right ? That's why moving the n25q032
> higher resolved the problem for you, right ?
>
> The problem is with the fragility of this code which matches the JEDEC
> ID and type of the SPI NOR. I recall Huang had some patches which tried
> to resolve this, not sure what the status of those patches is though.

Wait, what? OK, this makes things tricky. Does this patch really
change any behavior? How does it happen? I don't see any duplicated
entry with the same JEDEC ID (0x20ba16).

Could you give us some more details?