[PATCH] mtd: gpmi: Remove noisy error message

Brian Norris computersforpeace at gmail.com
Tue Nov 25 19:18:23 PST 2014


On Tue, Nov 11, 2014 at 06:16:29PM -0200, Fabio Estevam wrote:
> BTW, I don't see any other nand driver that prints error on the probe
> error path like this one.

You're probably still going to see failure prints like

  nand: No NAND device found

in nand_scan_ident(), right? Or does driver probe fail earlier than that
somehow?

In general, I don't think you can expect non-discoverable hardware types
not to complain at all when you falsely declare them as "present" in the
device tree.

If this is really the only thing being printed though, I can apply the
patch. It's not worth too much more discussion anyway, IMO.

(BTW, one thing you have going for you; you *do* print something when
you successfully probe. The absence of such a message in your log tells
you almost as much as the failure print you're trying to remove does.)

Brian



More information about the linux-mtd mailing list