[PATCH 2/3] mtd: spi-nor: remove the jedec_id/ext_id

Rafał Miłecki zajec5 at gmail.com
Wed Nov 5 22:21:22 PST 2014


On 6 November 2014 02:09, Huang Shijie <shijie.huang at intel.com> wrote:
>> 1) Do we need the if (info->id_len) check?
> yes. some chips may have short info->id_len, some chips may have long
> info->id_len.

Right, thanks.


>> 2) Shouldn't we use memcmp in the if (!strncmp(info->id, id, info->id_len))
> I prefer to memcmp too. But i misused with strncmp.
> You can send a patch to fix it. I can give you my Ack. :)

Well, you were sending V2 2 hours later anyway... you could fix that in it :|

-- 
Rafał



More information about the linux-mtd mailing list