Problems in Out of tree TI SDK omap2-nand driver (Re: [PATCH 3/3] nandtest: Introduce multiple reads & check iterations)

[Brian Norris]

On Mon, May 05, 2014 at 06:12:55PM +0000, Pekon Gupta wrote:
> >From: Ezequiel Garcia [mailto:ezequiel at vanguardiasur.com.ar]
> >All in all, I think it's still a nice improvement on stock nandtest.
> 
> I was just presenting my view that
> With multiple re-reads nand-test may fail randomly on some devices
> due of accumulation of bitflips because of read-disturb errors.

Read disturb is not totally "random." It has definite causes, and it
should be relatively obvious if we're observing it in the controlled
environment of nandtest, rather than amidst the complexity of UBI(FS)
scrubbing, wear-leveling, etc.

> However, this may not be the case on actual file-system like UBIFS
> where upper layer performs scrubbing to avoid bit-flip accumulation.
> 
> Otherwise I have no issue with the patch. So if Artem | Brian feel okay,
> they can anyways pick the patch.

For the record, I agree with Ezequiel. This is a good (small)
improvement to the test. If for any reason, we cannot reread the same
data consistently for 4 tries immediately after programming it, then we
have a big problem. And even if read disturb is causing an accumulation
of bitflips, I think this would be a nice way to view that progression.

Brian