[RFC PATCH] UBI: fix rb_tree node comparison in add_map

Brian Norris computersforpeace at gmail.com
Fri May 9 18:19:13 PDT 2014


Hi Artem,

On Sat, Mar 22, 2014 at 12:56:59AM +0100, Richard Weinberger wrote:
> Am 21.03.2014 20:54, schrieb Mike Snitzer:
> > The comparisons used in add_vol() shouldn't be identical.  Pretty sure
> > the following is correct but it is completely untested.
> > 
> > Signed-off-by: Mike Snitzer <snitzer at redhat.com>
> > ---
> >  drivers/mtd/ubi/fastmap.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > NOTE: I stumbled upon this code while implementing some rb_tree code
> >       (and looking for some existing rb_tree code as a reference).
> 
> Thanks a lot for pointing this out!
> 
> Acked-by: Richard Weinberger <richard at nod.at>

Bump?

I'm passing through my queue, and I occasionally see some obvious,
reviewed fixes like this one. Typically, you get around to them
eventually, but you never know. Do you prefer the "bump"?

Brian



More information about the linux-mtd mailing list