[REV3] mtd: nand: Prepare for Micron on-die ECC controller support.

[David Mosberger]

Gerhard,

On Mon, Mar 31, 2014 at 1:45 PM, Gerhard Sittig <gsi at denx.de> wrote:

> Isn't there the ONFI SETFEATURE request?  And don't you use this
> very request to disable and enable chip internal ECC support, to
> get the raw (uncorrected) bits after bitflips were detected?  So
> I understand that there is support to enable this mode at will,
> and we already have (or will have) code to do so.
>
> If we consider disabling on-die-ECC support when we find it
> enabled and know it's not what the user wants to run, then the
> next logical step might be to support enabling this feature if
> the user wants it and the chip doesn't have it enabled at this
> point in time.
>
> So I guess the buffers should get allocated as soon as the chip
> supports on-die-ECC.  (While the allocation should only get
> introduced in the phase where the raw-read and bitflip count gets
> added.)

The ECC-mode of the driver never changes.
Sure, what you describe could be implemented as an additional feature
in the future (I don't have any plans to do so since it makes little sense to
me, as no other ECC-mode uses the layout of the on-die-controller).

To be honest, I'm a bit confused: on the one hand, you're asking me to
simplify the patches into smaller pieces, on the other you seem to ask
for new features.

  --david
-- 
eGauge Systems LLC, http://egauge.net/, 1.877-EGAUGE1, fax 720.545.9768