[PATCH v1 3/3] mtd: nand: introduce a READMODE command

[Gerhard Sittig]

On Mon, 2014-03-31 at 11:50 -0600, David Mosberger-Tang wrote:
> 
> Would it be cleaner to define READMODE like this:
> 
> #define NAND_CMD_READMODE      (0x100 | NAND_CMD_READ0)

See 'git show 0be718e5525a' (the comments suggest that I took the
DEPLETE1 command as an inspiration), the code was not constructed
there either.  But I'm open to suggestions, let's see what others
think or whether there already is an established preference for
such aggregates.


> I'm updating my patch to take advantage of READMODE.

Can you identify other stuff that could get built in steps, to
chop the big change into pieces that are a little easier to
review and verify, to help getting your on-die-ECC introduction
accepted?

Will the better mapping to the current flow of command emission,
data fetching, and optional ECC handling become "a byproduct" of
constructing the total support from incremental building blocks?
Like starting with the "supported?" check, adding an "enabled?"
check, adding read/write support with mere boolean error
conditions, then add the re-read and bitflip count dance?

Splitting complex changes into logical groups helps in later
maintenance, too (bisection to identify and isolate problems,
extending or fixing clearly identified spots of restricted
functionality).


virtually yours
Gerhard Sittig
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de