[PATCH 1/2] mtd: denali_dt: Use devm_ioremap_resource()

Brian Norris computersforpeace at gmail.com
Wed Mar 26 02:24:19 EDT 2014


On Mon, Mar 03, 2014 at 09:21:06AM +0900, Jingoo Han wrote:
> On Saturday, March 01, 2014 1:21 AM, Dinh Nguyen wrote:
> > On Mon, 2014-02-24 at 01:08 +0000, Jingoo Han wrote:
> > > On Sunday, February 23, 2014 11:20 AM, Brian Norris wrote:
> > > > Your code here is not a direct replacement; Dinh originally used the
> > > > _nocache variant of ioremap, but you are replacing it with the standard
> > > > one. There is no difference between the two on several ARCH's, but I
> > > > can't guarantee that your patch is safe without confirmation/testing. So
> > > > I will not take this without an Ack or Tested-by from someone
> > > > knowledgeable about denali.
> > 
> > Sorry that it took a while to get around to this. But I was able to test
> > the patch and it looks fine.
> > 
> > Tested-by: Dinh Nguyen <dinguyen at altera.com>
> 
> I really appreciate your tested-by. :-)
> Thank you a lot.

Yes, thanks Dinh!

> > > According to the comment of devm_ioremap_resource(),
> > > 'devm_ioremap_resource()' ioremaps it either as cacheable or
> > > as non-cacheable memory depending on the resource's flags
> > > Thus, devm_ioremap_nocache() will be called automatically.

I see. Thanks for pointing that out. Pushed to l2-mtd.git!

Brian



More information about the linux-mtd mailing list