[PATCH v2] mtd: nand: omap: fix BCHx ecc.correct to return detected bit-flips in erased-page

Gupta, Pekon pekon at ti.com
Tue Mar 25 03:05:58 EDT 2014


Hi Brian,


>
>fixes: commit 62116e5171e00f85a8d53f76e45b84423c89ff34
>       mtd: nand: omap2: Support for hardware BCH error correction.
>
>In omap_elm_correct_data(), if bitflip_count in an erased-page is within the
>correctable limit (< ecc.strength), then it is not indicated back to the caller
>ecc->read_page().
>This mis-guides upper layers like MTD and UBIFS layer to assume erased-page as
>perfectly clean and use it for writing even if actual bitflip_count was
>dangerously high (bitflip_count > mtd->bitflip_threshold).
>
>This patch fixes this above issue, by returning 'stats' to caller
>ecc->read_page() under all scenarios.
>
>Reported-by: Brian Norris <computersforpeace at gmail.com>
>Signed-off-by: Pekon Gupta <pekon at ti.com>
>---
I you think this qualifies for stable then please mark it for
CC: <stable at vger.kernel.org> # 3.9.x+


with regards, pekon



More information about the linux-mtd mailing list