[PATCH v9 3/5] mtd: nand: omap: ecc.correct: omap_elm_correct_data: fix erased-page detection for BCHx_HW ECC schemes

Gupta, Pekon pekon at ti.com
Thu Mar 20 09:22:26 EDT 2014


>From: Brian Norris [mailto:computersforpeace at gmail.com]
[...]

>I see we update 'stat', but in the case that this is a correctable
>erased page, don't we just ignore it? i.e., you'll hit this case below
>(not shown here):
>
>	/* Check if any error reported */
>	if (!is_error_reported)
>		return 0;
>
>Perhaps this should be changed to:
>
>	if (!is_error_reported)
>		return stat;
>
>?
>
Thanks much. nice catch. I missed this scenario. I have just sent a fix for this.

[PATCH] mtd: nand: omap: ecc.correct: omap_elm_correct_data: return number of bit-flips detected in erased-page

with regards, pekon



More information about the linux-mtd mailing list