[PATCH v5 1/4] mtd: devices: elm: check for hardware engine's design constrains

[Gupta, Pekon]

Hi Brian,

>From: Brian Norris [mailto:computersforpeace at gmail.com]

Thanks a lot for picking up the other patch series.
These patches make OMAP NAND look cleaner, scalable and stable.

>> @@ -1559,9 +1561,10 @@ static int is_elm_present(struct omap_nand_info *info,
>>  	}
>>  	/* ELM module available, now configure it */
>>  	info->elm_dev = &pdev->dev;
>> -	if (elm_config(info->elm_dev, bch_type))
>> -		return -ENODEV;
>> -	return 0;
>> +	err = elm_config(info->elm_dev, bch_type,
>> +		(info->mtd.writesize / ecc->size), ecc->size, ecc->bytes);
>
>Isn't info->mtd.writesize / ecc->size the same as just ecc->steps?
>
'ecc->steps' gets its value in nand_scan_tail(), but this particular
check on ELM driver, gets executed before nand_scan_tail() is called
in driver probe(), so have do the ecc->steps calculation myself.

I'll include all other comments in next version..

with regards, pekon