[PATCH v7 1/3] ubi: Introduce read-only block devices on top of UBI volumes

Artem Bityutskiy dedekind1 at gmail.com
Wed Mar 5 05:57:34 EST 2014


On Mon, 2014-02-24 at 09:39 -0300, Ezequiel Garcia wrote:
> +/* Attach a block device to an UBI volume */
> +#define UBI_IOCVOLATTBLK _IO(UBI_VOL_IOC_MAGIC, 7)

Ezequiel,

please, change this before it goes upstream and instead, make the ioctls
accept a 'struct ubi_blkcreate_req' object pointer.

/**
 * blah
 * @padding1:  reserved for future, not used, has to be zeroed
 */
struct ubi_blkcreate_req {
	__s8 padding1[128];
} __packed;

This will make sure we have a possibility to extend this ioctl in the
future with something like volume creation flags etc. Otherwise, if we
need to add a flag, we'll have to introduce a new ioctl.

Thanks!

-- 
Best Regards,
Artem Bityutskiy




More information about the linux-mtd mailing list