[PATCH] UBI: block: do not use term "attach"

[Artem Bityutskiy]

On Tue, 2014-03-04 at 10:59 -0300, Ezequiel Garcia wrote:
> On Tue, Mar 04, 2014 at 02:57:38PM +0200, Artem Bityutskiy wrote:
> > On Tue, 2014-03-04 at 12:02 +0200, Artem Bityutskiy wrote:
> > > + * This feature is compiled in the UBI core, and adds a 'block' parameter
> > > + * to allow early creation of block devices on top of UBI volumes. Runtime
> > > + * block creation/removal for UBI volumes is provided through two UBI ioctls:
> > > + * UBI_IOCVOLATTBLK and UBI_IOCVOLDETBLK.
> > >   */
> > 
> > I think the ioctl names should also be consistent.
> > s/AT/CR/, s/DET/RM/, may be?
> > 
> 
> Ah, yes. Good catch.
> 
> Let's write them down, so we can see how they result: UBI_IOCVOLCRBLK,
> UBI_IOCVOLRMBLK. Aren't these too unreadable?

Dunno, the other ones are similarly unreadable.

> How about something along UBI_IOCBLK_CREAT UBI_IOCBLK_RM ?

Well, would be a little inconsistent, but more readable, yes. Usually
ioctl names to not have underscores, though, no?

-- 
Best Regards,
Artem Bityutskiy