[PATCH] UBI: block: do not use term "attach"

Ezequiel Garcia ezequiel.garcia at free-electrons.com
Tue Mar 4 05:46:25 EST 2014


On Tue, Mar 04, 2014 at 12:02:53PM +0200, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
> 
> We already use term attach/detach for UBI->MTD relations, let's not use this
> for UBI->ubiblock relations to avoid confusion. Just use 'create' and 'delete'

s/delete/remove

> instead. E.g., "create a R/O block device on top of a UBI volume".
> 
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
> ---
>  drivers/mtd/ubi/block.c | 28 ++++++++++++++--------------
>  1 file changed, 14 insertions(+), 14 deletions(-)
> 

Change looks good, except I'd like to change ubiblock_add/ubiblock_del
with ubiblock_create/ubiblock_remove for consistency.

I haven't been too consistent with this terms and it's a good time to
fix it.

Want me to prepare a patch?
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com



More information about the linux-mtd mailing list