UBI: fix rb_tree node comparison in add_map commit buggy?

Richard Weinberger richard at nod.at
Mon Jun 23 23:53:13 PDT 2014


Am 24.06.2014 06:59, schrieb Artem Bityutskiy:
> On Mon, 2014-06-23 at 21:07 +0200, Richard Weinberger wrote:
>> I think it would be better to "fix" the whole logic such that low volume ids go into
>> the left rb node instead of the right.
>> Just to avoid further confusion.
>> Artem, do you know why UBI does it the other way around for volume ids?
> 
> I do not remember. Probably no particular reason.
> 
> I'd suggest to do a quick fix first and submit to Linus for 3.16, and
> then people can do whatever logic streamlining for 3.17, makes sense?

Agreed!

Thanks,
//richard



More information about the linux-mtd mailing list