[PATCH v2 0/3] mtd: Add sysfs entries and account BBT blocks properly

[Gupta, Pekon]

Hi Ezequiel


>From: Ezequiel Garcia
>
>Here's a new round of the patchset to add sysfs entries for the ECC stats
>struct fields. See the discussion around previous version for context:
>
>http://lists.infradead.org/pipermail/linux-mtd/2014-March/052804.html
>
>Changes from v1:
>
>  * As agreed I've added a sysfs file per field to replace the ecc_stats
>    sysfs file. The current proposal follows the "one file per value" sysfs
>    rule, adding the following device attributes:
>    - corrected_bits (ecc_stats.corrected)
>    - uncorrectable_errors (ecc_stats.failed)

Just a minor nit-pick ..
If you are re-spinning the patch then can you rename "uncorrectable_errors"
to actual binding attribute (something like "ecc_failures"), because the errors
could be due to multiple reasons like:
- uncorrectable bitflips
- timeout waiting for I/O.
- error status from flash controller | device
- ...
These all conditions are accounted in ecc_stat->failed, not alone 
"uncorrectable" conditions.


with regards, pekon