[PATCH 1/1] fs/ubifs/super.c: replace count*size kzalloc by kcalloc

Artem Bityutskiy dedekind1 at gmail.com
Tue Jul 15 23:10:38 PDT 2014


On Mon, 2014-06-23 at 18:41 +0200, Fabian Frederick wrote:
> kcalloc manages count*sizeof overflow.
> 
> Cc: Artem Bityutskiy <dedekind1 at gmail.com>
> Cc: Adrian Hunter <adrian.hunter at intel.com>
> Cc: linux-mtd at lists.infradead.org
> Signed-off-by: Fabian Frederick <fabf at skynet.be>

In the commit message, please, try to not only tell _what_ you do,
but also _why_ you do this. And ideally, but not necessary for this
case, I think, how this was tested (e.g., compile-tested only).

Thanks! I'll apply this patch, and amend the commit message so that it
tells that kcalloc() makes better bob of the overflow checking.

-- 
Best Regards,
Artem Bityutskiy




More information about the linux-mtd mailing list