[PATCH] mtd: m25p80: Use OPCODE_QUAD_READ_4B for 4-byte addressing

Huang Shijie b32955 at freescale.com
Thu Jan 16 21:04:54 EST 2014


On Thu, Jan 16, 2014 at 01:05:29PM -0800, Brian Norris wrote:
> On Thu, Jan 16, 2014 at 01:09:34AM +0100, Marek Vasut wrote:
> > On Wednesday, January 15, 2014 at 04:48:55 PM, Geert Uytterhoeven wrote:
> > > From: Geert Uytterhoeven <geert+renesas at linux-m68k.org>
> > > 
> > > commit 3487a63955c34ea508bcf4ca5131ddd953876e2d ("drivers: mtd: m25p80: add
> > > quad read support") in -next added both the 3-byte OPCODE_QUAD_READ and the
> > > 4-byte OPCODE_QUAD_READ_4B, but incorrectly uses OPCODE_QUAD_READ for both
> > > 3-byte and 4-byte addressing.
> > > 
> > > Use OPCODE_QUAD_READ_4B in the 4-byte case to fix this.
> 
> Wow, I noticed this and had a patch privately queued over a month ago
> for this, but I forgot to send it out... Thanks for noticing!
> 
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas at linux-m68k.org>
> > 
> > Looks all right.
> > 
> > Acked-by: Marek Vasut <marex at denx.de>
> 
> Pushed to l2-mtd.git.
this is a bad news to me. I have to send out a new version for the SPI NOR framework.

could this patch be merged after my spi-nor patch set? or create a new patch based
on the spi-nor framework.

thanks
Huang Shijie




More information about the linux-mtd mailing list