[PATCH] mtd: m25p80: Use OPCODE_QUAD_READ_4B for 4-byte addressing

[Marek Vasut]

On Wednesday, January 15, 2014 at 04:48:55 PM, Geert Uytterhoeven wrote:
> From: Geert Uytterhoeven <geert+renesas at linux-m68k.org>
> 
> commit 3487a63955c34ea508bcf4ca5131ddd953876e2d ("drivers: mtd: m25p80: add
> quad read support") in -next added both the 3-byte OPCODE_QUAD_READ and the
> 4-byte OPCODE_QUAD_READ_4B, but incorrectly uses OPCODE_QUAD_READ for both
> 3-byte and 4-byte addressing.
> 
> Use OPCODE_QUAD_READ_4B in the 4-byte case to fix this.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas at linux-m68k.org>

Looks all right.

Acked-by: Marek Vasut <marex at denx.de>

> ---
>  drivers/mtd/devices/m25p80.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index bf358326c335..0e9e78acc677 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -1258,7 +1258,7 @@ pr_info("jid = 0x%p\n", jid);
>  			/* Dedicated 4-byte command set */
>  			switch (flash->flash_read) {
>  			case M25P80_QUAD:
> -				flash->read_opcode = OPCODE_QUAD_READ;
> +				flash->read_opcode = OPCODE_QUAD_READ_4B;
>  				break;
>  			case M25P80_FAST:
>  				flash->read_opcode = OPCODE_FAST_READ_4B;

Best regards,
Marek Vasut