[PATCH 1/2] mtd: bcm47xxpart: find boot partition by CFE magic

Brian Norris computersforpeace at gmail.com
Sun Jan 5 17:49:44 EST 2014


Hi Rafał,

On Sat, Dec 21, 2013 at 07:39:11PM +0100, Rafał Miłecki wrote:
> Some devices have even nicer-to-recognize CFE thanks to the magic.
> 
> Signed-off-by: Rafał Miłecki <zajec5 at gmail.com>
> ---
> This patch adds one line wider than 80 chars, however this improves code
> readability thanks to keeping one rule per line. I hope this can be
> accepted in this case.

I tripped on the same checkpatch error, and I thought the same thing
about readability. Probably worth an exception in this case. Forcing the
'||' or half the rule onto the next line wouldn't be too pretty.

> Both patches were verified with
> ./verify ../linux/l2-mtd/ mips-bcm47xx_defconfig < patch

Nice to know I'm not the only one running these tools :)

Both patches look good. Pushed to l2-mtd.git.

Brian



More information about the linux-mtd mailing list