Re: [PATCH 1/2] mtd/ts5500: Add dependency

Alexander Shiyan shc_work at mail.ru
Fri Feb 14 05:56:37 EST 2014


Пятница, 14 февраля 2014, 11:44 +01:00 от Jean Delvare <jdelvare at suse.de>:
> Hi Alexander,
> 
> On Fri, 14 Feb 2014 14:32:06 +0400, Alexander Shiyan wrote:
> > Пятница, 14 февраля 2014, 11:28 +01:00 от Jean Delvare <jdelvare at suse.de>:
> > > There is no point in displaying the TS5500-specific driver entries if
> > > TS5500 board support itself isn't enabled.
> > > 
> > > Signed-off-by: Jean Delvare <jdelvare at suse.de>
> > > Cc: David Woodhouse <dwmw2 at infradead.org>
> > > Cc: Brian Norris <computersforpeace at gmail.com>
> > > Cc: Vivien Didelot <vivien.didelot at savoirfairelinux.com>
> > > ---
> > > drivers/mtd/maps/Kconfig |    2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > --- linux-3.14-rc2.orig/drivers/mtd/maps/Kconfig	2014-02-14
> 11:21:15.116363700
> > > +0100
> > > +++ linux-3.14-rc2/drivers/mtd/maps/Kconfig	2014-02-14 11:23:53.286863374
> > > +0100
> > > @@ -124,7 +124,7 @@ config MTD_NETSC520
> > > 
> > > config MTD_TS5500
> > > tristate "JEDEC Flash device mapped on Technologic Systems TS-5500"
> > > -	depends on X86
> > > +	depends on TS5500 || (X86 && COMPILE_TEST)
> > 
> > TS5500 && (X86 || COMPILE_TEST) ?
> 
> Hmm, no. The way I wrote it is correct I believe. TS5500 itself depends
> on X86. The driver is only needed on TS5500, but can be test-built in
> any X86 kernel if needed.

If so, you are right. Sorry for noise.

---


More information about the linux-mtd mailing list