[PATCH] mtd: nand: fix off-by-one read retry mode counting

Brian Norris computersforpeace at gmail.com
Wed Feb 12 19:58:45 EST 2014


On Wed, Feb 12, 2014 at 04:46:34PM -0800, Brian Norris wrote:
> A flash may support N read retry voltage threshold modes, numbered 1
> through N (where mode 0 represents the initial state). However,
> nand_setup_read_retry() prematurely quits with an error when mode == N.

Scratch that; apparently N retry modes means we can use feature address
0 through N-1. So the off-by-one error is actually in
nand_do_read_ops(). I'll send a v2 shortly.

Brian



More information about the linux-mtd mailing list